Create approx_nearest_neighbours.py#13309
Create approx_nearest_neighbours.py#13309Aaditya-Chunekar wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Approximate Nearest Neighbor using random projection hashing. | ||
| """ | ||
|
|
||
| def __init__(self, dataset: np.ndarray, n_planes: int = 5, seed: int = 42): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.buckets = defaultdict(list) | ||
| self._build_index() | ||
|
|
||
| def _hash_vector(self, vec: np.ndarray) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/approx_nearest_neighbours.py, please provide doctest for the function _hash_vector
| signs = (vec @ self.planes.T) >= 0 | ||
| return "".join(["1" if s else "0" for s in signs]) | ||
|
|
||
| def _build_index(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/approx_nearest_neighbours.py, please provide doctest for the function _build_index
Please provide return type hint for the function: _build_index. If the function does not return a value, please provide the type hint as: def function() -> None:
| h = self._hash_vector(vec) | ||
| self.buckets[h].append(vec) | ||
|
|
||
| def query(self, q: np.ndarray) -> list[list[list[float] | float]]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: q
algorithms-keeper
bot
added
awaiting reviews
1 participant
Describe your change:
Checklist: